Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/1.0] fix(broker): fix race condition in exporter tests #7244

Merged
2 commits merged into from
Jun 10, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Description

Backport of #7225 to stable/1.0.

Miguel Pires added 2 commits June 10, 2021 09:24
Synchronizes accesses to the db's closeables list to avoid concurrent
modifications. Current usage is only concurrent in tests (which leads to
flaky tests) but this will also prevent new non-serialized accesses being
added in the future.

(cherry picked from commit 150a678)
@MiguelPires
Copy link
Contributor

bors r+

@ghost
Copy link

ghost commented Jun 10, 2021

👎 Rejected by too few approved reviews

@MiguelPires MiguelPires self-assigned this Jun 10, 2021
@MiguelPires MiguelPires self-requested a review June 10, 2021 10:10
Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

ghost pushed a commit that referenced this pull request Jun 10, 2021
7244: [Backport stable/1.0] fix(broker): fix race condition in exporter tests r=MiguelPires a=github-actions[bot]

# Description
Backport of #7225 to `stable/1.0`.

Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
@ghost
Copy link

ghost commented Jun 10, 2021

Build failed:

@MiguelPires
Copy link
Contributor

bors retry

@ghost
Copy link

ghost commented Jun 10, 2021

Build succeeded:

@ghost ghost merged commit 51d3911 into stable/1.0 Jun 10, 2021
@ghost ghost deleted the backport-7225-to-stable/1.0 branch June 10, 2021 12:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants