Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.0] use correct logical predecessor #7246

Merged
1 commit merged into from
Jun 10, 2021
Merged

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jun 10, 2021

Description

Back port of #7222 to 1.0

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@pihme pihme requested a review from Zelldon June 10, 2021 11:19
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Bors r+

ghost pushed a commit that referenced this pull request Jun 10, 2021
7246: Backport 7222  r=Zelldon a=pihme

## Description

Back port of #7222 to 1.0



Co-authored-by: pihme <pihme@users.noreply.github.com>
@saig0 saig0 changed the title Backport 7222 [Backport 1.0] use correct logical predecessor Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

Build failed:

@pihme
Copy link
Contributor Author

pihme commented Jun 10, 2021

bors retry

@ghost
Copy link

ghost commented Jun 10, 2021

Build succeeded:

@ghost ghost merged commit 2035eef into stable/1.0 Jun 10, 2021
@ghost ghost deleted the backport-7222 branch June 10, 2021 12:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants