[Backport stable/1.0] Remove flakiness from SmallMessageSizeTest #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
(cherry picked from commit a75e87f)
The second process instance that creates a job that can be activated does not really do anything for this test. The test is to check that a job is ignored when it's variables are too large to fit in a message. We can simply create the process instance, set the variables and try to activate it. It should return no jobs. In order to return immediately we do need to disable long polling. (cherry picked from commit 27625f5)
Move duplicate test code into the before method. This allows us to cleanup the actual tests. (cherry picked from commit 3c571aa)
Removes the flakiness from the test, by waiting until the job and the variables have all been created. (cherry picked from commit 6cafede)
The process model creation does not need to happen in a separate method, and could be inlined. And the helper was not necessary AFAIK. (cherry picked from commit 618a3b9)
(cherry picked from commit 11ac835)
The tests should create their own unique processes so they are not affecting each other. Similarly, the tests should focus on their own job type (job activation works across all processes for a specific job type). (cherry picked from commit 22d3b35)
9 tasks
korthout
approved these changes
Jun 15, 2021
|
Build succeeded: |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7276 to
stable/1.0.Relates to #7170