Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/1.0] Do not write unnecessary VariableRecord.UPDATED if the variable remains unchanged #7306

Merged
5 commits merged into from
Jun 16, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Description

Backport of #7296 to stable/1.0.

Adds #toString implementation to RecordedEvent to ease debugging.

(cherry picked from commit 41c8d21)
Changes from collecting the first two records (whose order is not
guaranteed) to grabbing all VariableRecord.UPDATED for that process
instance, ensuring if there's an extra one, regardless of order, the
test will catch it.

(cherry picked from commit ed4f180)
Avoids writing an unnecessary VariableRecord.UPDATED if the variable
remains unchanged. This reduces load by reducing the number of records,
and also avoids confusion as the variable really isn't updated.

(cherry picked from commit e1a161d)
Do not expect loop variables to be updated as their values do not
change. Additionally, bind stream to process instead of hardcoded
count to increase the test robustness.

(cherry picked from commit 7812fe9)
(cherry picked from commit 18a6bf5)
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@ghost
Copy link

ghost commented Jun 16, 2021

Build succeeded:

@ghost ghost merged commit ad1f55f into stable/1.0 Jun 16, 2021
@ghost ghost deleted the backport-7296-to-stable/1.0 branch June 16, 2021 16:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant