[Backport stable/1.0] Hard reject resolving incident with missing failed command #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
In case the failed command can no longer be found for the incident to resolve, we should not be able to resolve the incident. Instead, the resolve command should be rejected. This already happened, but it would simultaneously also write incident resolved (which seems conflicting). To match behavior of other unrecoverable parts in the engine, we just throw an exception during the processing, which stops any follow-up events from being written and rejects the command. (cherry picked from commit 2658a5f)
9 tasks
korthout
approved these changes
Jun 22, 2021
|
Build succeeded: |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7293 to
stable/1.0.relates to #7127