[Backports stable/1.0] Improve logging on election timeout #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves logging when an election occurs due to missing heartbeats. This fixes the issue of having very high "time since last heartbeat" due when there are no heartbeats, and it also shows that there is no known leader instead of just showing null. Additionally, adds logging when sending poll requests to log if we transition directly to candidate or, when not, to which members we are sending poll requests. (cherry picked from commit 59b264d)
Lowers the log level of every request/response send/received in Raft to trace. We send so many, logging all of them as debug simply generates too much noise. (cherry picked from commit 8f734fe)
ghost
pushed a commit
that referenced
this pull request
Jun 24, 2021
7363: [Backports stable/1.0] Improve logging on election timeout r=deepthidevaki a=npepinpe ## Description This PR backports #7348 to stable/1.0. There were some conflicts as the changes to the election timer logic are not backported to 1.0. ## Related issues backports #7348 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Jun 24, 2021
7363: [Backports stable/1.0] Improve logging on election timeout r=deepthidevaki a=npepinpe ## Description This PR backports #7348 to stable/1.0. There were some conflicts as the changes to the election timer logic are not backported to 1.0. ## Related issues backports #7348 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Jun 24, 2021
7363: [Backports stable/1.0] Improve logging on election timeout r=deepthidevaki a=npepinpe ## Description This PR backports #7348 to stable/1.0. There were some conflicts as the changes to the election timer logic are not backported to 1.0. ## Related issues backports #7348 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #7348 to stable/1.0. There were some conflicts as the changes to the election timer logic are not backported to 1.0.
Related issues
backports #7348
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: