[Backport stable/1.0] Fix flakiness in AdvertisedAddressTest #7367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Replaces individual Testcontainers dependencies in the parent pom for the more general Testcontainers BOM. This simplifies dependency management by having a single parent dependency, and child modules can include whichever Testcontainers module they want without having to include it in the parent module. (cherry picked from commit 5abc1ed)
Migrates the AdvertisedAddressTest to junit 5 as part of overarching goal to migrate all tests to junit 5. (cherry picked from commit 68c28ed)
Ensures all nodes know about each other as initial contact points to avoid flakiness where one node fails to probe another, and none of the other two nodes will ever probe it back since they don't know about it. This also avoids a bug in gossip where some times a node does not get updates from the other nodes via fanout. (cherry picked from commit c5a65a5)
(cherry picked from commit 2a978ad)
9 tasks
ghost
pushed a commit
that referenced
this pull request
Jun 25, 2021
|
Build failed: |
|
bors retry |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7358 to
stable/1.0.