Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revapi appearing in distribution dependencies #7415

Merged
1 commit merged into from Jul 2, 2021
Merged

Conversation

npepinpe
Copy link
Member

Description

This PR fixes a mistake where the prepare-offline profile will include revapi to all modules as a dependency, but did not specify it was in scope test, resulting in it appearing in the distribution. There is another PR which will apply this fix (and more) to develop and the stable/1.0 branch already, but we need to include this fix for the upcoming release.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

Ensure revapi is specified as a test dependency when going offline, as
otherwise it will be included in the distribution.
@npepinpe npepinpe requested a review from korthout June 30, 2021 17:02
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

LGTM 👍

EDIT: do you want to forward port this to develop?

@npepinpe
Copy link
Member Author

npepinpe commented Jul 1, 2021

bors merge

@npepinpe
Copy link
Member Author

npepinpe commented Jul 1, 2021

No, as I mentioned, there's already another PR with this fix targeting develop.

@npepinpe
Copy link
Member Author

npepinpe commented Jul 2, 2021

Why is bors not doing anything? 🤔

EDIT: this time it seems it worked, but I wonder why it did nothing for the first comment...

@npepinpe
Copy link
Member Author

npepinpe commented Jul 2, 2021

bors merge

@ghost
Copy link

ghost commented Jul 2, 2021

Build succeeded:

@ghost ghost merged commit 377c9a8 into release-1.1.0 Jul 2, 2021
@ghost ghost deleted the np-fix-dep branch July 2, 2021 08:39
@korthout
Copy link
Member

korthout commented Jul 2, 2021

Why is bors not doing anything? 🤔

I'm not sure, but Jenkins had problems receiving webhooks from github around the same time. Might be related. Let's keep an eye open whether it happens again.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants