[Backports stable/1.0] Fix flaky test analysis with integration tests #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the flaky test extractor profile such that it's only activated manually. The reasoning here is that this is only used for CI and not for local development, so it's fine to have to manually enable it. This also fixes the usage of the plugin, which was not working with failsafe since it was not looking in the right directory. The profile now has a property which it uses to specify whether to look into surefire-reports or failsafe-reports. It was done this way because normally the plugin expects a full directory, but here we don't know the project's directory, just that in there it should look up failsafe/surefire reports. So instead of specifying it on all projects, we just have to set one property before running maven. One downside is the plugin has to run in the post-integration-test phase, so we now unnecessarily package the application even for unit tests. (cherry picked from commit 7d8c54f)
(cherry picked from commit 2a264cc)
Dependency and plugin resolve when going offline produce a lot of noise which we don't care about. We can switch it to silent, and errors/warnings will still be logged correctly. You can always turn it back to noisy if you need to debug things. (cherry picked from commit 4cb9033)
(cherry picked from commit 6e9def6)
npepinpe
force-pushed
the
backport-7413-to-stable/1.0
branch
from
8a9e26a
to
c0e07ef
Compare
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #7413 to stable/1.0. The merge conflicts were all in the
parent/pom.xmland related to versions which have been updated on develop, but not here. I've kept the original versions to resolve them.Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: