New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol): prevent NullPointerException in BpmnElementType #8142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @megglos 💐
This change makes perfect sense 🎉
🙃 nothing blocking, but please consider the following before merging (you can simply inform bors when you're ready):
- your commit message title doesn't comply with our commit message guidelines, specifically
bpmn elements
should probably beprotocol
. - perhaps the pull request title could have a more meaningful name
- as the elementTypeName field can be null use Optional.ofNullable in getter
a7c7641
to
10ad6c4
Compare
@korthout thanks for the feedback, I adjusted the commit message as well as the title, is the latter now more clear? |
@megglos thanks! 👍 (we try to make the PR titles more human readable and avoid the commit type prefix, but at the same time we are not consistent with this ourselves, so don't worry about it 😆) |
bors merge |
Build succeeded: |
Successfully created backport PR #8146 for |
Successfully created backport PR #8147 for |
Description
As the elementTypeName field can be null use Optional.ofNullable in the getter.
Related issues
closes #8141
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: