test(raft): remove unnecessary test #8479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky. It is not clear what property this test is verifying. The current one is inherentaly non-deterministic as it expects a specific leader nodes which is not possible to guarantee.
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
Dec 28, 2021
8479: test(raft): remove unnecessary test r=deepthidevaki a=deepthidevaki ## Description Removed a test which was flaky. It is not clear what property this test is verifying. The current one is inherentaly non-deterministic as it expects a specific leader nodes which is not possible to guarantee. ## Related issues closes #8417 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
|
Build failed: |
|
bors retry Hm, weird, it ran out of memory. Last I had checked, we didn't even get close to the container's memory limits...but maybe instead we're busting the |
ghost
merged commit 
|
Successfully created backport PR #8489 for |
|
Successfully created backport PR #8490 for |
ghost
pushed a commit
that referenced
this pull request
Dec 28, 2021
ghost
pushed a commit
that referenced
this pull request
Dec 28, 2021
korthout
added
the
version:1.3.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed a test which was flaky. It is not clear what property this test is verifying. The current one is inherentaly non-deterministic as it expects a specific leader nodes which is not possible to guarantee.
Related issues
closes #8417
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: