Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/1.2] Improve stability of StreamProcessorReplayModeTest#shouldNotSetLastProcessedPositionIfLessThanSnapshotPosition #8676

Merged
1 commit merged into from Jan 27, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Description

Backport of #8667 to stable/1.2.

relates to #8558

* define a new stream processor phase: INITIAL
* the stream processor is created with the phase INITIAL instead of REPLAY
* use the new phase to determine when the stream processor starts to replay events
* the test case was flaky because the event was written before the stream processor started the replay. as a result, the event was skipped and the listener was not invoked as expected

(cherry picked from commit 4119759)
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@ghost
Copy link

ghost commented Jan 27, 2022

Build succeeded:

@ghost ghost merged commit 3c83b27 into stable/1.2 Jan 27, 2022
@ghost ghost deleted the backport-8667-to-stable/1.2 branch January 27, 2022 13:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants