Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7 delete process instance #147

Merged
merged 6 commits into from
Apr 7, 2022

Conversation

rohwerj
Copy link
Collaborator

@rohwerj rohwerj commented Dec 17, 2021

Branch is based on branch update_docs, as changes to docs are based on update for prior commits

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #147 (6453b2c) into develop (cd74c62) will increase coverage by 0.31%.
The diff coverage is 44.64%.

@@              Coverage Diff              @@
##             develop     #147      +/-   ##
=============================================
+ Coverage      45.92%   46.24%   +0.31%     
- Complexity       408      422      +14     
=============================================
  Files             38       38              
  Lines           2186     2223      +37     
  Branches         275      277       +2     
=============================================
+ Hits            1004     1028      +24     
- Misses          1016     1025       +9     
- Partials         166      170       +4     
Impacted Files Coverage Δ
...in/kotlin/adapter/AbstractRuntimeServiceAdapter.kt 0.90% <0.00%> (ø)
...nsion/src/main/kotlin/impl/RemoteRuntimeService.kt 89.61% <60.97%> (-5.24%) ⬇️
extension/src/main/kotlin/adapter/BatchAdapter.kt 75.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd74c62...6453b2c. Read the comment docs.

@zambrovski zambrovski added Prio: MUST Must be implemented Type: enhancement New feature or request labels Mar 30, 2022
Copy link
Collaborator

@zambrovski zambrovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comments - the remaining code is good and can be merged then.

@zambrovski zambrovski merged commit 0ecd859 into develop Apr 7, 2022
@zambrovski zambrovski deleted the feature/delete-process-instance branch April 7, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: MUST Must be implemented Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants