-
Notifications
You must be signed in to change notification settings - Fork 36
grpc-js support #201
Comments
Current version of grpc-js is 1.2.5. Tests against Camunda Cloud, so communicating via a TLS-secured nginx proxy. Node 12.10.0On Node 12.10.0, the Worker-Failure test exits with SIGFPE. Node 13.14.0On Node 13.14.0, Worker-integration exits with:
Node 14.2.0On Node 14.2.0, the Worker-integration test exits with:
Node 14.15.4On Node 14.15.4, the Worker-Failure test exits with:
Node 15.8.0On Node 15.8.0,
|
Opened an issue in the grpc-js repository: grpc/grpc-node#1682 |
Valgrind command:
Output:
|
It segfaults on: NZ It does not segfault from: GCE US (Iowa) |
Testing the pure JS client from NZ against a vanilla broker in Belgium segfaults. It's distance or some other geographical network factor. |
Here is a script for scaffolding a GCE Ubuntu 20.10 VM to run the test against Camunda Cloud:
|
This looks like an error related to the native module. I suspect that it should go away when we don't import anything from |
Is there any timeline / plan to remove grpc from the dependencies? It is causing us quite some headaches as it is the only non-pure-js dependency left. |
No, there is not. I need assistance to fix this. The grpc-node maintainers said:
|
Node 16.13.1 has fixed this issue. Now the grpc-js works with a caveat: the onConnection behaviour is distinct from the C-based library. 3 tests fail out of 136:
So some modifications will be necessary to align the behaviours. |
If I remove the c-based library support, then it will make Node 16.13.1 a minimum pre-requisite... |
It looks like this is the Node issue that fixed it: nodejs/node#38964. So it should be fixed from 16.6.1, 14.17.5, and 12.22.5. Node 16 - 16.6.0+It works with 16.9.1 - the version bundled with Electron 16. Node 14 - 14.17.5+It works with 14.17.5. Node 12 - Node - 12.22.5+It works with 12.22.5. |
I'm going to bite the bullet and release 2.4.0 with pure JS gRPC only. 2.0.0-2.3.0 versions of the package were released two years ago, under the old numbering scheme. |
The C grpc package is being deprecated in April, 2021. This task is to track the stability of the grpc-js implementation with a view to switching over to it at the default.
The text was updated successfully, but these errors were encountered: