-
Notifications
You must be signed in to change notification settings - Fork 36
Upgrades in @grpc/*
break library completely
#290
Comments
@grpc/*
break client completely@grpc/*
break library completely
When I run the reproducer according to the instructions, I see the following:
|
I can reproduce that it is working now 🎉. Seems like the issue may have been fixed upstream as the test bed always always installs a latest version of |
Searching for a reference in the It looks like the authors try to fix that issue on and of from with the different patches they've released in the last weeks, with the latest one being released last night: grpc/grpc-node#2337. Due to the severity of this issue should we still bump the dependendencies explicitly? Or pin them to a working version (i.e. |
Closing this issue. |
As documented here updating
zebee-node
and thereby semver minor bumping@grpc/*
dependencies breaks the library completely. It causes an unconditional termination. NouncaughtException
, no error.Expected Behavior
Library works as expected.
Current Behavior
Unconditional termination. No
uncaughtException
, no error. Have not seen such behavior ever before.Possible Solution
Pin dependencies to
@grpc/*
to last good known versions. Add integration tests / periodically check ifzebee-node
with latest dependencies still works.Steps to Reproduce
git clone git@github.com:barmac/zeebe-tls-connection-test.git cd zeebe-tls-connection-test npm ci npm run generate-certs docker-compose --env-file .env.insecure up
Verify that the
zebee-node-test
does not print topology information (installs latestzebee-node
).Verify that the
zeebe-node
test prints topology information (uses older, fixed versions of@grpc/*
).Context (Environment)
None.
Detailed Description
None.
Possible Implementation
None.
The text was updated successfully, but these errors were encountered: