Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Zeebe's JSON deserialization #130

Open
saig0 opened this issue Sep 21, 2021 · 2 comments
Open

Support Zeebe's JSON deserialization #130

saig0 opened this issue Sep 21, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@saig0
Copy link
Collaborator

saig0 commented Sep 21, 2021

Since version 1.2.0, Zeebe supports deserialization of its records from JSON to the Java objects. See here: https://github.com/camunda-cloud/zeebe/tree/develop/protocol-jackson

The Java client should support the JSON format and deserialize the records using the new module.

The current client deserializes the records into objects that are generated from the Protobuf schema. Since these objects are different, we could create a new client. In the long run, we might support only the JSON format with the official module.

@Zelldon
Copy link
Contributor

Zelldon commented Sep 22, 2021

This would mean I need to implement the deserialization in other languages if I want to implement a new hazelcast client right?

@saig0
Copy link
Collaborator Author

saig0 commented Sep 22, 2021

This would mean I need to implement the deserialization in other languages if I want to implement a new hazelcast client right?

If we drop the support for Protobuf then yes. A new client would need to write the POJOs by itself. It could not use the Protobuf schema to generate the POJOs.

This is a good point for keeping the Protobuf support. On the other side, the Protobuf schema must be maintained to keep it in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants