Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the configuration of ZBClient #52

Closed
jwulf opened this issue Mar 11, 2024 · 0 comments · Fixed by #57
Closed

Simplify the configuration of ZBClient #52

jwulf opened this issue Mar 11, 2024 · 0 comments · Fixed by #57
Assignees
Milestone

Comments

@jwulf
Copy link
Member

jwulf commented Mar 11, 2024

The ZBClient component supports a lot of backward-compatible constructor options, including multiple constructor signatures.

This makes modification and maintenance a challenge. While adding multi-tenancy support to the Zeebe client, this is causing a lot of friction and accidental complexity.

For the 8.5 release, I will simplify the constructor signature to be a Partial<ZBClientConfig>, and then make the configuration hydrator do the following:

Read all environment variables into a config map, then overwrite that map with any explicit configuration passed to the constructor.

This makes the configuration explicit and simple. The zero-conf constructor is default. All configuration from environment variables is applied, then anything that is explicitly passed to a ZBClient constructor overrides it.

@jwulf jwulf self-assigned this Mar 11, 2024
@jwulf jwulf added this to the 8.5.0 milestone Mar 11, 2024
@jwulf jwulf closed this as completed in #57 Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant