New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeler 1.12.0 accidently created sequence flows on top of each other #777

Closed
felix-mueller opened this Issue Apr 11, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@felix-mueller
Contributor

felix-mueller commented Apr 11, 2018

New Autoplace feature:

Reproduce:

  1. Modeler a gateway
  2. choose end event from context pad
  3. go back to gateway and choose task from context pad
  4. task is placed on top of existing sequence flow sometimes and then it creates a second sequence flow
  5. now i move the task and i end up with two sequence flows going to the end event.

Happens in many different scenarios that I end up with multiple sequence flows using auto-place.

This happens a lot for participants at trainings etc.
Also see https://forum.camunda.org/t/too-many-notify-calls-for-external-task-on-executionlistener/6823

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Apr 11, 2018

Member

This issue is probably related to the fact that people use auto place + insert the placed elements into existing flows afterwards.

Could this get fixed by bpmn-io/bpmn-js#774?

Member

nikku commented Apr 11, 2018

This issue is probably related to the fact that people use auto place + insert the placed elements into existing flows afterwards.

Could this get fixed by bpmn-io/bpmn-js#774?

@nevries

This comment has been minimized.

Show comment
Hide comment
@nevries

nevries Apr 11, 2018

Member

In the attached model, select gateway and click on task in the pad. Is that what you mean, @felix-mueller ?
777.bpmn.txt

Member

nevries commented Apr 11, 2018

In the attached model, select gateway and click on task in the pad. Is that what you mean, @felix-mueller ?
777.bpmn.txt

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Apr 11, 2018

Member

The later would be fixed by bpmn-io/bpmn-js#757.

Member

nikku commented Apr 11, 2018

The later would be fixed by bpmn-io/bpmn-js#757.

@felix-mueller

This comment has been minimized.

Show comment
Hide comment
@felix-mueller

felix-mueller Apr 11, 2018

Contributor

Combination of both would fix the mentioned problem I guess. Thanks @nikku

Besides this: Maybe it would be good to visualize two sequence flows on each other differently?
I dont have a specific idea at the moment how - I think colors are not a good idea.

Contributor

felix-mueller commented Apr 11, 2018

Combination of both would fix the mentioned problem I guess. Thanks @nikku

Besides this: Maybe it would be good to visualize two sequence flows on each other differently?
I dont have a specific idea at the moment how - I think colors are not a good idea.

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Apr 11, 2018

Member

I'd rather disallow the situation where two sequence flows overlap (where possible). As an example, the toolkit could make sure that two sequence flows with the same source and target are not shown as overlapping:

image

Member

nikku commented Apr 11, 2018

I'd rather disallow the situation where two sequence flows overlap (where possible). As an example, the toolkit could make sure that two sequence flows with the same source and target are not shown as overlapping:

image

@benhoffmann

This comment has been minimized.

Show comment
Hide comment
@benhoffmann

benhoffmann Apr 11, 2018

I think the new task should always be placed beneath the existing sequence flow, like nikku already proposed in bpmn-io/bpmn-js#757

This would mean that you cannot insert elements directly and use auto place at the same time, but I would consider this at least a consistent behavior.

benhoffmann commented Apr 11, 2018

I think the new task should always be placed beneath the existing sequence flow, like nikku already proposed in bpmn-io/bpmn-js#757

This would mean that you cannot insert elements directly and use auto place at the same time, but I would consider this at least a consistent behavior.

@benhoffmann

This comment has been minimized.

Show comment
Hide comment
@benhoffmann

benhoffmann Apr 11, 2018

Besides this: Maybe it would be good to visualize two sequence flows on each other differently?
I dont have a specific idea at the moment how - I think colors are not a good idea

Maybe it is already sufficient to display sequence flows always in the foreground to prevent them being hidden behind tasks or other activities?

  • colors are definitely not a good option

benhoffmann commented Apr 11, 2018

Besides this: Maybe it would be good to visualize two sequence flows on each other differently?
I dont have a specific idea at the moment how - I think colors are not a good idea

Maybe it is already sufficient to display sequence flows always in the foreground to prevent them being hidden behind tasks or other activities?

  • colors are definitely not a good option

@nikku nikku added the backlog label Apr 19, 2018

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 25, 2018

Member

The latest nightly will ensure that there won't be duplicate sequence flows anymore.

Closed via ae26472.

Member

nikku commented Jul 25, 2018

The latest nightly will ensure that there won't be duplicate sequence flows anymore.

Closed via ae26472.

@nikku nikku closed this Jul 25, 2018

@wafflebot wafflebot bot removed the backlog label Jul 25, 2018

@nikku

This comment has been minimized.

Show comment
Hide comment
@nikku

nikku Jul 25, 2018

Member

The actual fix happened here: bpmn-io/bpmn-js#774.

Member

nikku commented Jul 25, 2018

The actual fix happened here: bpmn-io/bpmn-js#774.

@nikku nikku added this to the M24 milestone Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment