Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeler 1.12.0 accidently created sequence flows on top of each other #777

Closed
felix-mueller opened this issue Apr 11, 2018 · 9 comments
Closed
Labels
BPMN bug Something isn't working modeling
Milestone

Comments

@felix-mueller
Copy link
Member

New Autoplace feature:

Reproduce:

  1. Modeler a gateway
  2. choose end event from context pad
  3. go back to gateway and choose task from context pad
  4. task is placed on top of existing sequence flow sometimes and then it creates a second sequence flow
  5. now i move the task and i end up with two sequence flows going to the end event.

Happens in many different scenarios that I end up with multiple sequence flows using auto-place.

This happens a lot for participants at trainings etc.
Also see https://forum.camunda.org/t/too-many-notify-calls-for-external-task-on-executionlistener/6823

@nikku
Copy link
Member

nikku commented Apr 11, 2018

This issue is probably related to the fact that people use auto place + insert the placed elements into existing flows afterwards.

Could this get fixed by bpmn-io/bpmn-js#774?

@nevries
Copy link
Member

nevries commented Apr 11, 2018

In the attached model, select gateway and click on task in the pad. Is that what you mean, @felix-mueller ?
777.bpmn.txt

@nikku
Copy link
Member

nikku commented Apr 11, 2018

The later would be fixed by bpmn-io/bpmn-js#757.

@felix-mueller
Copy link
Member Author

Combination of both would fix the mentioned problem I guess. Thanks @nikku

Besides this: Maybe it would be good to visualize two sequence flows on each other differently?
I dont have a specific idea at the moment how - I think colors are not a good idea.

@nikku
Copy link
Member

nikku commented Apr 11, 2018

I'd rather disallow the situation where two sequence flows overlap (where possible). As an example, the toolkit could make sure that two sequence flows with the same source and target are not shown as overlapping:

image

@nikku nikku added bug Something isn't working BPMN modeling labels Apr 11, 2018
@benhoffmann
Copy link

I think the new task should always be placed beneath the existing sequence flow, like nikku already proposed in bpmn-io/bpmn-js#757

This would mean that you cannot insert elements directly and use auto place at the same time, but I would consider this at least a consistent behavior.

@benhoffmann
Copy link

benhoffmann commented Apr 11, 2018

Besides this: Maybe it would be good to visualize two sequence flows on each other differently?
I dont have a specific idea at the moment how - I think colors are not a good idea

Maybe it is already sufficient to display sequence flows always in the foreground to prevent them being hidden behind tasks or other activities?

  • colors are definitely not a good option

@nikku nikku added the backlog Queued in backlog label Apr 19, 2018
@nikku
Copy link
Member

nikku commented Jul 25, 2018

The latest nightly will ensure that there won't be duplicate sequence flows anymore.

Closed via ae26472.

@nikku nikku closed this as completed Jul 25, 2018
@ghost ghost removed the backlog Queued in backlog label Jul 25, 2018
@nikku
Copy link
Member

nikku commented Jul 25, 2018

The actual fix happened here: bpmn-io/bpmn-js#774.

@nikku nikku added this to the M24 milestone Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN bug Something isn't working modeling
Projects
None yet
Development

No branches or pull requests

4 participants