Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(self-managed): enrich local kubernetes cluster guide #1520

Merged
merged 4 commits into from Nov 29, 2022
Merged

Conversation

mary-grace
Copy link
Contributor

@mary-grace mary-grace commented Nov 19, 2022

Based on this forum post it appears we're missing a step in the process.

What is the purpose of the change

Enrich local Kubernetes cluster guide since it was copied as it is as part of the C8SM docs restructure.

Are there related marketing activities

No.

When should this change go live?

No specific date, as soon as possible.

PR Checklist

  • My changes apply to an already released version, and I have added them to the relevant /versioned_docs directory.
  • My changes apply to future versions, and I have added them to the main /docs directory.
  • My changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer.

@mary-grace
Copy link
Contributor Author

@christinaausley - apologies for not associating this with a particular version! I wasn't sure what the proper protocol was when it's not version-specific (whether already released or future) but also is ideally going to be released with the next version of docs. Let me know if you have any questions, and feel free to edit if there's a more clear way to communicate this change.

@akeller
Copy link
Member

akeller commented Nov 21, 2022

@aabouzaid can you have a look at this feedback and PR?

@akeller
Copy link
Member

akeller commented Nov 23, 2022

We will likely need to add this to 8.1 as well so it's in the current docs.

@aabouzaid
Copy link
Member

@mary-grace do you mind if take over this?
because that guide was moved as it is as part of the restructure I did.

So we will need to make more structure (I will do that if it's ok with you).

@mary-grace
Copy link
Contributor Author

@aabouzaid Please do! You know far more about this topic than I do :) Thanks for taking it on!

@aabouzaid aabouzaid changed the title added step to add repo docs(self-managed): enrich local kubernetes cluster guide Nov 28, 2022
@aabouzaid aabouzaid self-assigned this Nov 28, 2022
@aabouzaid
Copy link
Member

aabouzaid commented Nov 28, 2022

@mary-grace great, thank you 🚀
@christinaausley I've updated the PR, and it's ready for review.

@aabouzaid aabouzaid added kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have) component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Nov 28, 2022
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor adjustments to wording/typos for clarity in my latest commit. Let me know if you have any questions about these 👍

@aabouzaid aabouzaid merged commit 7fb9f67 into main Nov 29, 2022
@aabouzaid aabouzaid deleted the add-repo branch November 29, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants