Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace interceptor link with hint to add full oauth url #2265

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

jonathanlukas
Copy link
Contributor

@jonathanlukas jonathanlukas commented Jun 27, 2023

The interceptor is not required in 8.2 anymore. Instead, here is a useful piece of information about the oauth url

closes #2237

Description

Until 8.2, it was required to use some kind of interceptor to achieve oauth behaviour on zeebe. As of 8.2, zeebe has an embedded oauth mode.

Now, it becomes more relevant to document the oauth url for the self-managed setup.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

The interceptor is not required in 8.2 anymore. Instead, here is a useful piece of information about the oauth url
@jonathanlukas jonathanlukas added component:modeler Issues related with Modeler project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Jun 27, 2023
Apply change to docs as well
@jonathanlukas jonathanlukas changed the title Update deploy-to-self-managed.md Replace interceptor link with hint to add full oauth url Jun 27, 2023
@akeller
Copy link
Member

akeller commented Jun 27, 2023

@camunda/modeling-dev & @npepinpe (grabbing your names from here), can you have a look or assign a reviewer?

nikku
nikku previously approved these changes Jun 28, 2023
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Stylistically I'd propose the keycloak URL as an example (as other providers are possible).

I believe this fixes #2237?

…ed.md

Co-authored-by: Nico Rehwaldt <nico.rehwaldt@camunda.com>
…r/deploy-to-self-managed.md

Co-authored-by: Nico Rehwaldt <nico.rehwaldt@camunda.com>
@jonathanlukas
Copy link
Contributor Author

@nikku good catch I did not find this issue 😅 I accepted your suggestions. This will make the docs more future-proof as C8 could support more different identity providers ootb.

@jonathanlukas jonathanlukas requested a review from nikku June 28, 2023 12:13
@nikku nikku merged commit d8048e6 into main Jun 28, 2023
5 checks passed
@nikku nikku deleted the jonathanlukas-patch-1 branch June 28, 2023 19:01
@nikku
Copy link
Member

nikku commented Jun 28, 2023

🎉 Great contribution 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:modeler Issues related with Modeler project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth URL unclear for Desktop Modeler to C8 SM
3 participants