Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for ExporterConfiguration and then replace GSON with Jackson #4037

Closed
pihme opened this issue Mar 11, 2020 · 1 comment
Closed
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@pihme
Copy link
Contributor

pihme commented Mar 11, 2020

Description

  • Increase unit tests for exporter configuration and concrete exporter configuration users (e.g. ElasticsearchExporter, Debug Exporter etc.)
  • Identify data types used for existing exporters
  • Refactor implementation of data binding mechanism to use Jackson instead of GSON
  • Verify that the behavior did not change

Background

  • ExporterConfiguration is one of the last places where we use GSON, whereas in many other places we use Jackson consistently
  • It is used to bind settings from a configuration source to instances of a exporter configuration classe´
  • Ideally we would only use Jackson consistently throughout the codebase
  • Changing the implementation is a bit risky. The default output of GSON and Jackson are not identical (e.g. for classes like Duration, DataSize), so changing the implementation will likely change behavior
@pihme pihme added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Mar 11, 2020
@npepinpe npepinpe added Priority: Low scope/broker Marks an issue or PR to appear in the broker section of the changelog labels May 6, 2020
@npepinpe
Copy link
Member

Done in #9854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

No branches or pull requests

3 participants