Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Java client, I can deploy DMN resources #8075

Closed
Tracked by #8083
saig0 opened this issue Oct 27, 2021 · 2 comments · Fixed by #8985
Closed
Tracked by #8083

In the Java client, I can deploy DMN resources #8075

saig0 opened this issue Oct 27, 2021 · 2 comments · Fixed by #8985
Assignees
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/clients-java Marks an issue or PR to appear in the Java client section of the changelog

Comments

@saig0
Copy link
Member

saig0 commented Oct 27, 2021

Description

In the Java client, I should be able to deploy DMN resources. The deployment itself should work with the current state. But we need to switch to the new gRPC deploy request to receive the deployed decisions.

  • switch to the new gRPC deploy request and response
  • extend the command response object by adding the deployed decisions
  • adjust the JavaDoc to make it clear that DMN resources are supported

blocked by #8067
blocked by #8074

@saig0 saig0 added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/clients-java Marks an issue or PR to appear in the Java client section of the changelog labels Oct 27, 2021
@saig0 saig0 added this to the Evaluate DMN decisions milestone Oct 27, 2021
@saig0 saig0 added this to Planned in Zeebe Oct 27, 2021
@korthout
Copy link
Member

korthout commented Nov 4, 2021

The Java client offers support to deploy a process where the resource can be provided in multiple ways, including as an instance of io.camunda.zeebe.model.bpmn.BpmnModelInstance. Do we want to offer something similar for DMN resources?

@saig0
Copy link
Member Author

saig0 commented Nov 5, 2021

Do we want to offer something similar for DMN resources?

No. As far as I know, it is not common to create a DMN via the model API. If users request this feature then we could add it later.

The existing methods should be sufficient to deploy DMN files.

@korthout korthout self-assigned this Mar 21, 2022
@korthout korthout moved this from Planned to In progress in Zeebe Mar 21, 2022
@KerstinHebel KerstinHebel removed this from In progress in Zeebe Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/clients-java Marks an issue or PR to appear in the Java client section of the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants