Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Template generator] FeelMode should default to disabled for inbound element templates #2282

Closed
chillleader opened this issue Apr 2, 2024 · 2 comments
Closed

[Template generator] FeelMode should default to disabled for inbound element templates #2282

chillleader opened this issue Apr 2, 2024 · 2 comments
Labels
kind:task Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.

Comments

@chillleader
Copy link
Member

What should we do?

We should have different defaults for FeelModefor inbound and outbound templates.

  • Outbound: default FeelMode is optional (current behavior)
  • Inbound: default FeelMode is disabled

Why should we do it?

In inbound connectors it's much less common to use FEEL expressions because most inbound connectors are process-scoped and not instance-scoped (thus no access to process variables, the only exception from this is the HTTP polling connector).
@chillleader chillleader added the kind:task Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Apr 2, 2024
This was referenced Apr 2, 2024
Merged
Merged
@Oleksiivanov
Copy link
Contributor

PR -> #2264

@chillleader
Copy link
Member Author

Duplicate of #2251

@chillleader chillleader marked this as a duplicate of #2251 Apr 2, 2024
@chillleader chillleader closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:task Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chillleader @Oleksiivanov