653 fr slack connector post message add option to post to an existing thread #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johnBgood
reviewed
Jun 19, 2024
| @@ -133,4 +100,42 @@ protected static Stream<String> loadTestCasesFromResourceFile(final String fileW | |||
| }) | |||
| .map(Arguments::of); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think you might need to fix your formatted, this bloc has been moved apparently
| @@ -54,11 +47,17 @@ class ChatPostMessageDataTest { | |||
| } | |||
| } | |||
|
|
|||
| @Mock private MethodsClient methodsClient; | |||
| @@ -80,7 +79,7 @@ void invoke_shouldThrowExceptionWhenUserWithoutEmail() throws SlackApiException, | |||
| void invoke_shouldFindUserIdByEmail(String email) throws SlackApiException, IOException { | |||
| // Given | |||
| ChatPostMessageData chatPostMessageData = | |||
| new ChatPostMessageData(email, "plainText", "test", null); | |||
| new ChatPostMessageData(email, "thread_ts", "", "test", null); | |||
There was a problem hiding this comment.
plainText disappeared is it expected?
| } | ||
| ] | ||
| """; | ||
| [ |
| } | ||
| } | ||
| """; | ||
| { |
mathias-vandaele
force-pushed
the
653-fr-slack-connector-post-message-add-option-to-post-to-an-existing-thread
branch
from
4dd650b
to
142222f
Compare
…nd connector refactor the test to include the new field
mathias-vandaele
force-pushed
the
653-fr-slack-connector-post-message-add-option-to-post-to-an-existing-thread
branch
from
142222f
to
f6ee79c
Compare
johnBgood
deleted the
653-fr-slack-connector-post-message-add-option-to-post-to-an-existing-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users were not able to create a new thread from an existing message or add a message to an existing thread. this solves the issues.
I added a new optional field to the slack outbound connector
threadwhich takes the id of a message to start a thread from.This id has to be gotten from the output mapping
message.tswhich contains the id of the posted messageRelated issues
There might be an issue in the future when an user wants to add messages (using camunda) inside a thread that has been create by a normal user (human), as I don't know how to retrieve the id.
closes https://github.com/camunda/team-connectors/issues/653