Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can invoke a function with a named parameter that contains whitespaces #311

Closed
saig0 opened this issue Aug 3, 2021 · 3 comments · Fixed by #381
Closed

I can invoke a function with a named parameter that contains whitespaces #311

saig0 opened this issue Aug 3, 2021 · 3 comments · Fixed by #381

Comments

@saig0
Copy link
Member

saig0 commented Aug 3, 2021

Is your feature request related to a problem? Please describe.
I can invoke a function with a named parameter.

If the named parameter contains whitespace then the engine fails to parse the expression.

Describe the solution you'd like
A named parameter of a function invocation can contain whitespaces.

Related issues

  • Camunda BPM:
  • Zeebe broker:
@saig0 saig0 self-assigned this Aug 3, 2021
@saig0 saig0 removed their assignment Aug 23, 2021
@ubaldop
Copy link
Contributor

ubaldop commented Dec 29, 2021

Can I look at this, please?

@saig0
Copy link
Member Author

saig0 commented Dec 29, 2021

@p3trur0 I'm sorry 😅 but the issue itself should be fixed after the refactoring of the parser. See here: https://github.com/camunda/feel-scala/blob/master/src/main/scala/org/camunda/feel/impl/parser/FeelParser.scala#L450

However, there is no test case to prove that the issue us fixed. Feel free to contribute a test case 👍

@ubaldop
Copy link
Contributor

ubaldop commented Dec 30, 2021

Test added.

@saig0 saig0 closed this as completed in #381 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants