Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null in unary-test expressions should resolve to ValNull #679

Closed
remcowesterhoud opened this issue Jul 12, 2023 · 0 comments · Fixed by #689
Closed

Null in unary-test expressions should resolve to ValNull #679

remcowesterhoud opened this issue Jul 12, 2023 · 0 comments · Fixed by #689
Assignees

Comments

@remcowesterhoud
Copy link
Contributor

Describe the bug
A comparison using null or a non-existing variable should resolve to a ValNull, except when it comes to comparisons. E.g.:

// Non existing less than
non-existing < 10
    ValNull

// null greater than
null > 10
    ValNull

For unary-test expressions one would expect the same behavior:

// Expected
null in < 10
    ValNull

Instead, it will return a ValBoolean(true):

// Actual
null in < 10
    ValBoolean(true)

Note that this is a regression introduced in #676. Before the return of these expressions would be ValBoolean(false)!
There are tests verifying these that are ignored for now. They must be unignored when this is fixed:

Environment

  • FEEL engine version: None affected yet. Only on the main branch
@saig0 saig0 self-assigned this Jul 13, 2023
@saig0 saig0 changed the title Null and non-existing variable in unary-test expressions should resolve to ValNull Null in unary-test expressions should resolve to ValNull Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants