Skip to content

Commit

Permalink
merge: #12423
Browse files Browse the repository at this point in the history
12423: Disable faulty subject-case commitlint rule r=korthout a=korthout

## Description

<!-- Please explain the changes you made here. -->

We had disabled the subject case 'always' 'lowercase' rule, because our CONTRIBUTING guide does not specify any rules for casing.

However, from `@commitlint/config-conventional` we inherit a different rule:

Never
- sentence-case
- start-case
- pascal-case
- upper-case

This meant that we still get an error on a commit message like:
```
fix: Do the thing
subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
```

I've swapped the subject-case rule so we disable the inheritted rule.

## Related issues

<!-- Which issues are closed by this PR or are related -->

encountered in #11902 



Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
  • Loading branch information
zeebe-bors-camunda[bot] and korthout committed Apr 14, 2023
2 parents 7922c92 + 7b3d98c commit fd19810
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion commitlint.config.js
Expand Up @@ -59,7 +59,7 @@ module.exports = {
'scope-empty': [0, 'never'],
'scope-max-length': [0, 'always', Infinity],
'scope-min-length': [0, 'always', 0],
'subject-case': [0, 'always', 'lower-case'],
'subject-case': [0, 'never', ['sentence-case', 'start-case', 'pascal-case', 'upper-case']],
'subject-empty': [0, 'never'],
'subject-full-stop': [0, 'never', '.'],
'subject-max-length': [0, 'always', Infinity],
Expand Down

0 comments on commit fd19810

Please sign in to comment.