Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove environments from Dockerfile #10104

Closed
npepinpe opened this issue Aug 17, 2022 · 6 comments · Fixed by #10286
Closed

Remove environments from Dockerfile #10104

npepinpe opened this issue Aug 17, 2022 · 6 comments · Fixed by #10286
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

Description

Once we have Kubernetes 1.23+ in all the stages, it would be great to simplify our Dockerfile and remove the APP_ENV usage. We won't really need the development version of the image anymore since we will have access to ephemeral containers, letting us attach an image with all our utilities as a sidecar container of our production image.

@npepinpe npepinpe added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 17, 2022
@menski
Copy link
Contributor

menski commented Aug 19, 2022

Once we have Kubernetes 1.23+ in all the stages
Might not be needed for SaaS as we don't have the dev image there

We would only need to wait for our zeebe-io cluster. Until then we need this as a way to have the dev container available.

@megglos megglos self-assigned this Sep 7, 2022
@megglos
Copy link
Contributor

megglos commented Sep 7, 2022

@npepinpe how should we best inform the whole team about this change or is everyone already familiar with ephemeral container usage?
Currently checking https://iximiuz.com/en/posts/kubernetes-ephemeral-containers myself.

@npepinpe
Copy link
Member Author

npepinpe commented Sep 7, 2022

I could do a short intro to ephemeral containers. I don't think there's enough to make a full techtalk (e.g. 1h of contents), but if there's no topic we could use that slot for a presentation.

@npepinpe
Copy link
Member Author

npepinpe commented Sep 7, 2022

I think anyway only Chris uses the dev image, so at the moment he would be the only one impacted

@npepinpe
Copy link
Member Author

npepinpe commented Sep 7, 2022

Of course, as you're doing this, you could also consider doing the intro to ephemeral containers yourself if you'd like :)

@megglos
Copy link
Contributor

megglos commented Sep 7, 2022

With the changes I tried debugging via ephemeral containers on a benchmark.

kubectl -n <ns> debug -it -c debugger --image=eclipse-temurin:17-jdk-focal --target=zeebe <pod>

which resulted in

Targeting container "zeebe". If you don't see processes from this container it may be because the container runtime doesn't support this feature.
If you don't see a command prompt, try pressing enter.
root@meg-10104-ephemeral-benchmark-zeebe-0:/# ps x
    PID TTY      STAT   TIME COMMAND
      1 ?        Ss     0:00 tini -- /usr/local/bin/startup.sh
      7 ?        Sl     4:48 /opt/java/openjdk/bin/java -Xms128m -XX:+ExitOnOutOfMemoryError -Dfile.encoding=UTF-8 -classpath /usr/local/zeebe/config:/usr/local/zeebe/lib/* -Dapp.name=b
    178 pts/0    Ss     0:00 bash
    187 pts/0    R+     0:00 ps x

The filesystem of the zeebe process can be accessed via the proc folder:

cd /proc/<pid>/root

@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants