Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup manager can delete backup #10208

Closed
Tracked by #9606
, #10809
...
deepthidevaki opened this issue Aug 29, 2022 · 0 comments · Fixed by #10819
Closed
Tracked by #9606
, #10809
...

Backup manager can delete backup #10208

deepthidevaki opened this issue Aug 29, 2022 · 0 comments · Fixed by #10819
Assignees
@deepthidevaki
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0-alpha3 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@deepthidevaki
Copy link
Contributor

Related #9979
@deepthidevaki deepthidevaki added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 29, 2022
@deepthidevaki deepthidevaki mentioned this issue Aug 29, 2022
Closed
58 tasks
@npepinpe npepinpe mentioned this issue Sep 21, 2022
Closed
10 tasks
@npepinpe npepinpe self-assigned this Sep 21, 2022
@deepthidevaki deepthidevaki mentioned this issue Oct 25, 2022
Closed
21 tasks
@deepthidevaki deepthidevaki mentioned this issue Oct 26, 2022
Merged
10 tasks
@remcowesterhoud remcowesterhoud added the version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 label Dec 6, 2022
@deepthidevaki deepthidevaki mentioned this issue Dec 8, 2022
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Dec 8, 2022
@zeebe-bors-camunda @deepthidevaki
merge: #11215
e9529a9 
11215: Ensure list operation fails if backup store is not reachable r=deepthidevaki a=deepthidevaki

## Description

Previously, the list operation was implemented in a best-effort way such that it returns an empty list if s3 store is not reachable. This was acceptable because of how it was used previously. But, now we rely on it for delete as well as list backup apis. So `backupStore:list` must be reliable and must fail if it cannot accurately list all requested ones. Otherwise, we would return incorrect information to the user. This PR fixes this and adds tests to verify this behavior.

## Related issues

related #10847 #10208 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0-alpha3 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
4 participants
@npepinpe @deepthidevaki @Zelldon @remcowesterhoud