Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractBackupStoreIT tests are detected as duplicate test runs #10254

Closed
lenaschoenburg opened this issue Sep 1, 2022 · 1 comment · Fixed by #10269
Closed

AbstractBackupStoreIT tests are detected as duplicate test runs #10254

lenaschoenburg opened this issue Sep 1, 2022 · 1 comment · Fixed by #10269
Assignees
@lenaschoenburg
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@lenaschoenburg
Copy link
Member

On Jenkins we run a script to detect duplicate test runs. The S3BackupStoreIT tests are abstract and run for two S3 implementations. This is then detected as duplicate runs which makes the Jenkins pipeline fail.

Open questions:

  • Do we want to use the same script on GHA?
  • Does failsafe handle this correctly so that one test run doesn't overwrite the other?
@lenaschoenburg lenaschoenburg added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) labels Sep 1, 2022
@megglos
Copy link
Contributor

megglos commented Sep 2, 2022 •
edited
Loading

Triage:
Nicolas: should we add duplicate detection to GHA => YES
@npepinpe will create a follow-up issue

@lenaschoenburg lenaschoenburg self-assigned this Sep 2, 2022
@lenaschoenburg lenaschoenburg mentioned this issue Sep 2, 2022
Merged
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaschoenburg lenaschoenburg

Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(backup): reusable testkit that verifies backup store behavior camunda/camunda
3 participants
@megglos @lenaschoenburg @Zelldon