Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect duplicate test runs in GHA #10260

Closed
npepinpe opened this issue Sep 2, 2022 · 3 comments · Fixed by #10389 or #10415
Closed

Detect duplicate test runs in GHA #10260

npepinpe opened this issue Sep 2, 2022 · 3 comments · Fixed by #10389 or #10415
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented Sep 2, 2022

Description

In our Jenkins pipeline, we had an extra step to detect duplicate test runs. This was added because we root caused corrupted test reports to being due to the same tests being ran twice in parallel. It would be useful to keep this check to ensure this never happens again, at least while we're running multiple test engines as well.

@npepinpe npepinpe added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Sep 2, 2022
@npepinpe
Copy link
Member Author

npepinpe commented Sep 2, 2022

/cc @oleschoenburg

@megglos megglos self-assigned this Sep 16, 2022
@megglos
Copy link
Contributor

megglos commented Sep 16, 2022

Decided to work on it next as I'm learning about the CI anyway and it will bring us further to deprecate the jenkins pipeline.

@megglos
Copy link
Contributor

megglos commented Sep 20, 2022

encountered false-positive and the fact that tee swallowed the maven exit. Thus reopening.

@megglos megglos reopened this Sep 20, 2022
zeebe-bors-camunda bot added a commit that referenced this issue Sep 20, 2022
10415: fix(ci): use bash shell for maven run  r=megglos a=megglos

## Description

Ensures a fail fast behavior as this includes [github setting](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference) `set -eo pipefail` which makes sure failures in a pipe chain are not lost and any maven test failure causes the build to fail.

## Related issues

closes #10260



Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Sep 20, 2022
10409: feat(backup): add metrics for checkpoints r=deepthidevaki a=deepthidevaki

## Description

Added following metrics:
- number of checkpoint records processed per partition. Can be filtered by `result = created` or `result = ignored`.
- last checkpoint id and last checkpoint position per partition. It is updated in both leader and followers.

PS:- This PR does not add panels to grafana dashboard. 

## Related issues

closes #10385 



10410: feat: gateway endpoint to pause exporting r=oleschoenburg a=oleschoenburg

Adds an actuator `/exporting` that supports a `pause` operation. On `POST /actuator/exporting/pause`, the current topology is checked for completeness (all brokers available, all partitions have the expected number of members). If this fails, exporting is not paused and the request returns status code 500. If the topology is complete, the actuator sends pause requests to all `(broker, partition)` pairs. Only if all requests succeed we return status code 204, otherwise 500.

This also fixes a bug where pausing exporting would fail if no exporters are configured.

closes #9630


10415: fix(ci): use bash shell for maven run  r=megglos a=megglos

## Description

Ensures a fail fast behavior as this includes [github setting](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference) `set -eo pipefail` which makes sure failures in a pipe chain are not lost and any maven test failure causes the build to fail.

## Related issues

closes #10260



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
3 participants