Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the 17.0.5 JDK #10372

Closed
aivinog1 opened this issue Sep 15, 2022 · 10 comments · Fixed by #10810 or #10932
Closed

Update to the 17.0.5 JDK #10372

aivinog1 opened this issue Sep 15, 2022 · 10 comments · Fixed by #10810 or #10932
Assignees
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4

Comments

@aivinog1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Because there is a bug with JDK that is breaking the cpu-shares parameter of the Docker environment it would be cool to see updates of the JDK in the base Zeebe's Docker image.

Describe the solution you'd like
Just update the JDK in Zeebe's Docker Image to 17.0.5 as soon as it is available.

Describe alternatives you've considered
You could switch to the 18 or even 19 JDKs but I think that you shouldn't do this in the patch versions :)

Additional context
The JDK bug heavily affects our Zeebe environment because we use this argument when running docker containers. As I can see right now Zeebe is using this version of the image.

@aivinog1 aivinog1 added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Sep 15, 2022
@aivinog1
Copy link
Contributor Author

Also, I would like to see some patches to the 8.0.x version as well :)

@megglos megglos self-assigned this Sep 16, 2022
@megglos
Copy link
Contributor

megglos commented Sep 16, 2022

17.0.5 is scheduled for 2022-10-18

@npepinpe
Copy link
Member

Seems to have been fixed in Java 17.0.4, see the release notes.

Closed by #10810

@aivinog1
Copy link
Contributor Author

Seems to have been fixed in Java 17.0.4, see the release notes.

Closed by #10810

Hey @npepinpe! But it seems to me, not in the Temurin JDK: https://foojay.io/java-17/?tab=component&version=17.0.4&quarter=072022
This is the 17.0.4 version:
image
And this is the 17.0.5 version:
image

@aivinog1
Copy link
Contributor Author

You can see links on this page: https://adoptium.net/temurin/releases/

@npepinpe npepinpe reopened this Oct 25, 2022
@npepinpe
Copy link
Member

I understood they follow the same versioning, but it seems not. Strange though that they always have the same versions, down to patches, yet they don't include exactly the same content (ignoring the commercial features obviously)

@aivinog1
Copy link
Contributor Author

Strange though that they always have the same versions, down to patches, yet they don't include exactly the same content (ignoring the commercial features obviously)
Yep, we thought in the same way but seems to be it is not true :)

Also, I want to mention that it would be cool to backport this in the 8.0.x also :)

@megglos
Copy link
Contributor

megglos commented Nov 4, 2022

it's underway docker-library/official-images#13486

zeebe-bors-camunda bot added a commit that referenced this issue Nov 8, 2022
10934: [Backport stable/8.1] build(docker): update base image to jdk 17.0.5 r=megglos a=backport-action

# Description
Backport of #10932 to `stable/8.1`.

relates to #10372

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@megglos
Copy link
Contributor

megglos commented Nov 8, 2022

@aivinog1 actually the stable/8.0 branch is not using digest pinning and points to the general 17-jre-focal tag of the temurin image. Thus the next patch release will automatically be based on the latest 17 tag, being at least the 17.0.5 one from now on.

@aivinog1
Copy link
Contributor Author

aivinog1 commented Nov 8, 2022

@aivinog1 actually the stable/8.0 branch is not using digest pinning and points to the general 17-jre-focal tag of the temurin image. Thus the next patch release will automatically be based on the latest 17 tag, being at least the 17.0.5 one from now on.

Awesome, thanks :)

@remcowesterhoud remcowesterhoud added the version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4 label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4
Projects
None yet
4 participants