Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling/disabling job stream/push feature #12029

Closed
Tracked by #11231
npepinpe opened this issue Mar 15, 2023 · 2 comments
Closed
Tracked by #11231

Allow enabling/disabling job stream/push feature #12029

npepinpe opened this issue Mar 15, 2023 · 2 comments
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.

Comments

@npepinpe
Copy link
Member

npepinpe commented Mar 15, 2023

Description

To avoid undue overhead during development, we're currently merging various job stream/push features into our codebase. Since it will take some time before everything is wrapped up and ready, including a release in between, we should avoid introducing errors into existing deployments by putting the feature behind a feature flag.

As of now, nothing we've merged is affecting existing deployments, but this may change. Since I will be off before the release, @koevskinikola and @deepthidevaki, please check in next week to evaluate the risk and see if we need this issue before the 8.2 release, and if so, implement it.

One simple solution for now would be to add a flag, which returns noop implementations for all introduced behavior changes.

@npepinpe npepinpe added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Mar 15, 2023
@npepinpe npepinpe added planning/discuss To be discussed at the next planning. and removed planning/discuss To be discussed at the next planning. labels Mar 15, 2023
@npepinpe npepinpe self-assigned this Apr 4, 2023
@npepinpe
Copy link
Member Author

npepinpe commented Aug 17, 2023

Todo:

  • Return appropriate error code in the gateway to prevent clients from opening job streams
  • Return appropriate error code in the broker to prevent gateways from opening job streams (and log a warning, so operators are aware of configuration mismatch)
  • Update worker to not retry when it fails to open a stream with the specific error code, and log a warning to the user (so they are aware of configuration mismatch)

@deepthidevaki deepthidevaki removed their assignment Aug 18, 2023
@npepinpe
Copy link
Member Author

npepinpe commented Jan 4, 2024

Will not do. Instead, you can disable it on the client side.

@npepinpe npepinpe closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
Projects
None yet
Development

No branches or pull requests

2 participants