Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovate fails updating docker digest #12577

Closed
megglos opened this issue Apr 27, 2023 · 5 comments
Closed

Renovate fails updating docker digest #12577

megglos opened this issue Apr 27, 2023 · 5 comments
Assignees
@megglos
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.12 Marks an issue as being completely or in parts released in 8.1.12 version:8.2.4 Marks an issue as being completely or in parts released in 8.2.4 version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@megglos
Copy link
Contributor

megglos commented Apr 27, 2023 •
edited

Description

For main, stable/8.1, probably also stable/8.2 renovate seems to have issues updating the digest.

DEBUG: Digest is not updated(packageFile="Dockerfile", branch="renovate/stable/8.1-eclipse-temurin-17.x")
{
  "baseBranch": "stable/8.1",
  "manager": "dockerfile",
  "expectedValue": "sha256:22f133769ce2b956d150ab749cd4630b3e7fbac2b37049911aa0973a1283047c",
  "foundValue": "sha256:b10df4660e02cf944260b13182e4815fc3e577ba510de7f4abccc797e93d9106"
}
WARN: Error updating branch: update failure(branch="renovate/stable/8.1-eclipse-temurin-17.x")
{
  "baseBranch": "stable/8.1"
}

See further logs at https://app.renovatebot.com/dashboard#github/camunda/zeebe/
@megglos megglos added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Apr 27, 2023
@megglos megglos mentioned this issue Apr 27, 2023
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Apr 27, 2023
@zeebe-bors-camunda @megglos
merge: #12579
be047b4 
12579: deps(docker): update eclipse-temurin docker digest r=npepinpe a=megglos

## Description
Digests were already outdated as renovate fails to update them, see #12577 .
Backport to 8.0 is not needed as we don't use digest pinning there and renovate actually updated the tag successfully there, see #12566 .

## Related issues

relates #12577

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@backport-action backport-action mentioned this issue Apr 27, 2023
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Apr 27, 2023
@zeebe-bors-camunda @megglos
merge: #12581
5819767 
12581: [Backport stable/8.2] deps(docker): update eclipse-temurin docker digest r=megglos a=backport-action

# Description
Backport of #12579 to `stable/8.2`.

relates to #12577 #12577

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@megglos megglos mentioned this issue Apr 27, 2023
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Apr 27, 2023
@zeebe-bors-camunda @megglos
merge: #12582
1fb2215 
12582: [Backport stable/8.1] deps(docker): update eclipse-temurin docker digest r=npepinpe a=megglos

# Description
Backport of #12579 to `stable/8.1`.

relates to #12577

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@megglos
Copy link
Contributor Author

megglos commented Apr 27, 2023

turns out the recent introduction of JVM and JAVA_VERSION broke the updates

          {
            "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
            "datasource": "docker",
            "depType": "stage",
            "replaceString": "${JVM}:${JAVA_VERSION}-jre-focal@sha256:54f64f1cf8e9b984a92d06d3ad5c10fbbb9e9869144f1f45decdf530d64a4163",
            "skipReason": "invalid-name",
            "updates": []
          },

@megglos megglos self-assigned this Apr 27, 2023
@megglos megglos mentioned this issue Apr 27, 2023
Merged
megglos added a commit that referenced this issue Apr 27, 2023
@megglos
deps(docker): inline nested image name variables
28c04bb 
Renovate otherwise fails parsing the image name, see issue #12577.
zeebe-bors-camunda bot added a commit that referenced this issue Apr 27, 2023
@zeebe-bors-camunda @megglos
merge: #12586
1acb768 
12586: deps(docker): inline nested image name variables r=oleschoenburg a=megglos

## Description

Renovate otherwise fails parsing the image name, see issue #12577.
Need to verify after merge.

## Related issues

relates #12577


Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@backport-action backport-action mentioned this issue Apr 27, 2023
Merged
backport-action pushed a commit that referenced this issue Apr 27, 2023
@megglos @github-actions
deps(docker): inline nested image name variables
a731aa4 
Renovate otherwise fails parsing the image name, see issue #12577.

(cherry picked from commit 28c04bb)
zeebe-bors-camunda bot added a commit that referenced this issue Apr 27, 2023
@zeebe-bors-camunda @megglos
merge: #12588
c3c5afe 
12588: [Backport stable/8.2] deps(docker): inline nested image name variables r=megglos a=backport-action

# Description
Backport of #12586 to `stable/8.2`.

relates to #12577

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
This was referenced Apr 28, 2023
Merged
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Apr 28, 2023
@zeebe-bors-camunda @megglos
merge: #12602
d7a0344 
12602: deps(renovate): enable dependency dashboard r=megglos a=megglos

## Description

Curious to try + [allows us to trigger a run manually,](renovatebot/config-help#814) at least for testing I would like to enable it temporarily.

relates to #12577

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue May 1, 2023
@zeebe-bors-camunda @megglos
merge: #12603
94dd43b 
12603: [stable/8.1] build(docker): pin complete docker image digest r=megglos a=megglos

## Description

The previous value lacked the algorithm, this broke automated updates of the digest by renovate. On `main` & `stable/8.2` we already include the algorithm in the variable, so this PR aligns the 8.1 stable branch on that.

By that chance I also backported the dynamic digest value in the golden file we already have on 8.2 and main. This will also allow renovate updates to go through smoothly, as the golden file needs no manual update.

## Related issues

relates #12577

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@remcowesterhoud remcowesterhoud added version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 version:8.1.12 Marks an issue as being completely or in parts released in 8.1.12 version:8.2.4 Marks an issue as being completely or in parts released in 8.2.4 and removed version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 labels May 3, 2023
@koevskinikola
Copy link
Member

ZPA triage:

  • @megglos it looks like ZDP is already working on this issue. Is there any reason why the issue is on the ZPA board as well?
  • ZPA will remove it from the team board. If there is anything we need to do, please re-add it to the ZPA board.

@megglos
Copy link
Contributor Author

megglos commented May 26, 2023

changes are applied, I'm monitoring it till the next updates are applied to all branches

@megglos megglos mentioned this issue May 30, 2023
Merged
zeebe-bors-camunda bot added a commit that referenced this issue May 31, 2023
@zeebe-bors-camunda @megglos
merge: #12894
b6fe4c0 
12894: [stable/8.0] build(docker): digest pinning for base images r=megglos a=megglos

## Description

I just realized a recent change #12590 which disabled renovate doing patch updates on docker tags, so we only update digests but never tags, will actually leave the `stable/8.0` branch unmaintained as we didn't use digest pinning there.

Instead of adjusting the renovate config for just `stable/8.0` I figured it would be easier to just add digest pinning to it as well.

## Related issues

relates to #12577 



Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
@lenaschoenburg lenaschoenburg added version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 release/8.0.16 labels Jun 7, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
@Zelldon
Copy link
Member

Zelldon commented Nov 9, 2023

@megglos wondering why this is open but in the done column @megglos ? 🤔

@megglos
Copy link
Contributor Author

megglos commented Nov 9, 2023

thanks for raising, I somehow assumed it gets closed when moving it to done 🤔

@megglos megglos closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@megglos megglos

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.12 Marks an issue as being completely or in parts released in 8.1.12 version:8.2.4 Marks an issue as being completely or in parts released in 8.2.4 version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@megglos @lenaschoenburg @koevskinikola @Zelldon @remcowesterhoud