Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Error Handler implementation for Job Streamer #12796

Closed
Tracked by #11711
berkaycanbc opened this issue May 17, 2023 · 0 comments · Fixed by #12826
Closed
Tracked by #11711

Provide Error Handler implementation for Job Streamer #12796

berkaycanbc opened this issue May 17, 2023 · 0 comments · Fixed by #12826
Assignees
@berkaycanbc
Labels
component/engine kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@berkaycanbc
Copy link
Contributor

berkaycanbc commented May 17, 2023 •
edited

Is your feature request related to a problem? Please describe.
When pushing a job fails, we should trigger the JobYieldProcessor to make the related job available for long polling.

Describe the solution you'd like
JobIntent.YIELD command should be appended when job push fails. This will be achieved through registering the error handler to RemoteJobStreamErrorHandlerService inside JobStreamServiceStep.

Describe alternatives you've considered
/

Additional context
Blocked by:
@berkaycanbc berkaycanbc mentioned this issue May 17, 2023
Closed
@berkaycanbc berkaycanbc added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. component/engine kind/feature Categorizes an issue or PR as a feature, i.e. new behavior and removed kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. labels May 17, 2023
@berkaycanbc berkaycanbc self-assigned this May 17, 2023
@berkaycanbc berkaycanbc mentioned this issue May 22, 2023
Merged
14 tasks
zeebe-bors-camunda bot added a commit that referenced this issue May 26, 2023
@zeebe-bors-camunda @berkaycanbc
merge: #12826
bf48fc0 
12826: Provide error handler implementation for job streamer r=koevskinikola a=berkaycanbc

## Description

An error handler implementation that appends a `YIELD` command to the log stream should be provided.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #12796 



Co-authored-by: berkaycanbc <berkay.can@camunda.com>
@lenaschoenburg lenaschoenburg added the version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 label Jun 7, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berkaycanbc berkaycanbc

Labels
component/engine kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide error handler implementation for job streamer camunda/camunda
3 participants
@megglos @lenaschoenburg @berkaycanbc