Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve output mapping incident on a none end event #12833

Closed
npepinpe opened this issue May 23, 2023 · 2 comments · Fixed by #12876
Closed

Cannot resolve output mapping incident on a none end event #12833

npepinpe opened this issue May 23, 2023 · 2 comments · Fixed by #12876
Labels
area/ux Marks an issue as related to improving the user experience component/engine good first issue Marks an issue as simple enough for first time contributors kind/bug Categorizes an issue or PR as a bug severity/mid Marks a bug as having a noticeable impact but with a known workaround version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6 version:8.3.0-alpha3 Marks an issue as being completely or in parts released in 8.3.0-alpha3 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@npepinpe
Copy link
Member

Describe the bug

There was an incident in one of the chaos test models, where a none end event had an output mapping referencing a non-existent variable source to be mapped to target. I resolved the incident by adding a dummy variable (the mapping should not have been there anyway), but then the process was stuck on the none end event.

See https://bru-2.operate.camunda.io/eeef5734-cfd6-47a5-a2ed-5fe13269e589/processes/2251799815205221

To Reproduce

Add the following test case to io.camunda.zeebe.engine.processing.incidentOutputMappingIncidentTest:

          {
            "None end event",
            ENGINE
                .deployment()
                .withXmlResource(
                    Bpmn.createExecutableProcess(PROCESS_ID)
                        .startEvent()
                        .endEvent("endEventId", b -> b.zeebeOutputExpression("foo", "bar"))
                        .done()),
            "endEventId",
            false
          },

Expected behavior

I can resolve incidents on a none end event.

Environment:

  • Zeebe Version: 8.2.3
  • Configuration: SaaS - G3 S
@npepinpe npepinpe added the kind/bug Categorizes an issue or PR as a bug label May 23, 2023
@korthout
Copy link
Member

As a workaround, users can use Process Instance Modification to re-activate the end event

@korthout korthout added good first issue Marks an issue as simple enough for first time contributors severity/mid Marks a bug as having a noticeable impact but with a known workaround area/ux Marks an issue as related to improving the user experience component/engine labels May 24, 2023
@korthout
Copy link
Member

ZPA triage:

  • should be simple to resolve good-first-issue (just implement the onComplete method on NoneEndEventBehavior in the EndEventProcessor)
  • since it's low-hanging fruit and may effect users we would like to tackle it sooner than later.

zeebe-bors-camunda bot added a commit that referenced this issue May 31, 2023
12876: fix(engine): cannot resolve output mapping incident on a none end event r=korthout a=skayliu

## Description

In [PR#10618](#10618), we add the `apply output mappings for none end events` feature for the `none end events` on  `onActive()` method.

It's will produce incident when a none end event had an output mapping referencing a non-existent variable `source` to be mapped to `target` and stuck the process.

To fix this, we need to move the `variableMappingBehavior.applyOutputMappings()` from on `onActivate()` to `onComplete()`, because incident resolution will attempt to complete the end event while that method was unimplemented.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #12833 



Co-authored-by: skayliu <skay463@163.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 2, 2023
12945: [Backport stable/8.2] fix(engine): cannot resolve output mapping incident on a none end event r=korthout a=backport-action

# Description
Backport of #12876 to `stable/8.2`.

relates to #12833

Co-authored-by: skayliu <skay463@163.com>
@lenaschoenburg lenaschoenburg added the version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6 label Jun 7, 2023
@Zelldon Zelldon added the version:8.3.0-alpha3 Marks an issue as being completely or in parts released in 8.3.0-alpha3 label Jul 6, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Marks an issue as related to improving the user experience component/engine good first issue Marks an issue as simple enough for first time contributors kind/bug Categorizes an issue or PR as a bug severity/mid Marks a bug as having a noticeable impact but with a known workaround version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6 version:8.3.0-alpha3 Marks an issue as being completely or in parts released in 8.3.0-alpha3 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants