Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition request does not return extra partitions #562

Closed
ThorbenLindhauer opened this issue Nov 23, 2017 · 4 comments · Fixed by #1274
Closed

Partition request does not return extra partitions #562

ThorbenLindhauer opened this issue Nov 23, 2017 · 4 comments · Fixed by #1274

Comments

@ThorbenLindhauer
Copy link
Member

Topic creation as a retry mechanism which can lead to the situation where a requested topic with x partitions is created with more than x partitions. In this case, the partition request implemented in #530 returns only x partitions. Similar behavior occurs in the case of deployments, i.e. a deployment is only distributed to x partitions.

Reason: Both endpoints rely on collecting all the created partitions. This currently only respects the first x partition CREATED events on the system log.

@menski
Copy link
Contributor

menski commented Nov 23, 2017

This means if we deploy a workflow on a topic which has retry partitions the deployment is successful but the workflow does not exist on all partition of the topic? So the client will fail to start workflow instances while doing round robin as the topology also contains retry partitions? Is that correct?

@menski menski added broker and removed bug labels Nov 23, 2017
@ThorbenLindhauer
Copy link
Member Author

Yes, correct.

@menski menski added this to the Partitioning milestone Nov 23, 2017
@menski
Copy link
Contributor

menski commented Nov 23, 2017

Okay thanks for confirmation then I think we should address that in the near future after finishing our current topics.

@ThorbenLindhauer
Copy link
Member Author

Here's a test for the partition request: e619691#diff-7bb9375e8ef161a823e4fe842066351dR123

@menski menski added the ready label Dec 18, 2017
@menski menski removed this from the Partitioning milestone Jan 8, 2018
@menski menski removed the ready label Jan 8, 2018
bors bot added a commit that referenced this issue Sep 10, 2018
1274: Remove all topic related from codebase r=menski a=Zelldon

closes #1224 
closes #1077 
closes #1080
closes #1123
closes #562
closes #423

Co-authored-by: Christopher Zell <zelldon91@gmail.com>
Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
@bors bors bot closed this as completed in #1274 Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants