Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the loading and creating of segments from SegmentedJournal #7604

Closed
deepthidevaki opened this issue Aug 6, 2021 · 0 comments · Fixed by #9714
Closed

Split the loading and creating of segments from SegmentedJournal #7604

deepthidevaki opened this issue Aug 6, 2021 · 0 comments · Fixed by #9714
Assignees
@deepthidevaki
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@deepthidevaki
Copy link
Contributor

deepthidevaki commented Aug 6, 2021 •
edited
Loading

SegmentedJournal is responsible for too many things. We can split the loading and creating of the segments to another class. SegmentedJournal will be only an entry point to the journal.

The new class would know how to load a segment file and how to create a segment file.

Follow up #6221
@deepthidevaki deepthidevaki added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 6, 2021
@npepinpe npepinpe added this to Planned in Zeebe Aug 9, 2021
@npepinpe npepinpe moved this from Planned to Ready in Zeebe Aug 9, 2021
This was referenced Aug 18, 2021
Open
Closed
@npepinpe npepinpe moved this from Ready to Planned in Zeebe Oct 29, 2021
@KerstinHebel KerstinHebel removed this from Planned in Zeebe Mar 23, 2022
@npepinpe npepinpe mentioned this issue Jun 24, 2022
Closed
@deepthidevaki deepthidevaki self-assigned this Jul 4, 2022
@deepthidevaki deepthidevaki mentioned this issue Jul 6, 2022
Merged
10 tasks
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split loading and managing segments out of SegmentedJournal camunda/camunda
3 participants
@npepinpe @deepthidevaki @Zelldon