Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sortpom on the bom module #8037

Closed
korthout opened this issue Oct 21, 2021 · 3 comments · Fixed by #9339
Closed

Enable sortpom on the bom module #8037

korthout opened this issue Oct 21, 2021 · 3 comments · Fixed by #9339
Assignees
Labels
area/project Marks an issue as related to project management (e.g. PR templates, editor config, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@korthout
Copy link
Member

It seems the sortpom-plugin is not enabled on the bom/pom.xml. Let's enable it

Originally posted by @korthout in #8032 (comment)

@korthout korthout added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Oct 21, 2021
@npepinpe npepinpe added this to Planned in Zeebe Oct 22, 2021
@KerstinHebel KerstinHebel removed this from Planned in Zeebe Mar 23, 2022
@npepinpe npepinpe added the area/project Marks an issue as related to project management (e.g. PR templates, editor config, etc.) label Apr 20, 2022
@npepinpe npepinpe self-assigned this May 9, 2022
@npepinpe
Copy link
Member

npepinpe commented May 9, 2022

Do you remember why we don't use the spotless built-in sortPom?

https://github.com/diffplug/spotless/blob/main/plugin-maven/README.md#sortpom

@npepinpe
Copy link
Member

npepinpe commented May 9, 2022

Anyway, the biggest blocker here is that profile inheritance is sketchy in Maven. You don't actually inherit profiles, but they can be activated for child modules. What this means is, if you have a profile autoFormat defined in zeebe-bom, you can activate it and it will be enabled for zeebe-parent. However, you cannot extend it or modify it in zeebe-parent.

In our case, this means we would need to move the licensing configuration into the bom as well, not just spotless. This could be a good push for us to consider using spotless for licensing first, that way all we need is, well, spotless.

@korthout
Copy link
Member Author

korthout commented May 9, 2022

Do you remember why we don't use the spotless built-in sortPom?

Historical. No time spend on it when we switched to spotless.

@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/project Marks an issue as related to project management (e.g. PR templates, editor config, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants