Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test hypothesis that ExternalJarClassLoader can load resources from JAR #8982

Closed
aivinog1 opened this issue Mar 25, 2022 · 0 comments · Fixed by #9159
Closed

Test hypothesis that ExternalJarClassLoader can load resources from JAR #8982

aivinog1 opened this issue Mar 25, 2022 · 0 comments · Fixed by #9159
Labels
area/test Marks an issue as improving or extending the test coverage of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@aivinog1
Copy link
Contributor

Description

I have such a problem: my interceptor cannot load resources placed in the JAR. It couldn't find it. Let's write some tests for it in the io.camunda.zeebe.util.jar.ExternalJarClassLoaderTest. Also, I would like that it would be backported in 1.2.x versions.
@aivinog1 aivinog1 added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Mar 25, 2022
@aivinog1 aivinog1 mentioned this issue Apr 17, 2022
Merged
10 tasks
@npepinpe npepinpe added area/test Marks an issue as improving or extending the test coverage of the project team/distributed and removed team/distributed labels Apr 19, 2022
zeebe-bors-camunda bot added a commit that referenced this issue Apr 21, 2022
@zeebe-bors-camunda @aivinog1
merge: #9159
32736ed 
9159: test(gateway): add tests for the `io.camunda.zeebe.util.jar.ExternalJarClassLoader` and resources in jar. r=npepinpe a=aivinog1

## Description

<!-- Please explain the changes you made here. -->
I've decided to create this one to be sure that my resources will be properly loaded and could be accessible from the class loader.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #8982 



Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test Marks an issue as improving or extending the test coverage of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
4 participants
@npepinpe @deepthidevaki @Zelldon @aivinog1