Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-java-format is not kept up-to-date #9024

Closed
korthout opened this issue Mar 30, 2022 · 0 comments · Fixed by #9025
Closed

google-java-format is not kept up-to-date #9024

korthout opened this issue Mar 30, 2022 · 0 comments · Fixed by #9025
Assignees
@korthout
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@korthout
Copy link
Member

Description

The google-java-format plugin is not managed by Dependabot because the plugin is defined as part of spotless. Specifically, the google-java-format version is configured in a spotless specific configuration.

We should find a way to keep this version automatically up-to-date.

Potential solution ideas include:

  • unlikely to work: defining the version as a specifically named maven property
  • likely to work: defining the google-java-format maven plugin as a maven dependency to spotless
  • manual: subscribing to google-java-format releases
@korthout korthout added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Mar 30, 2022
@korthout korthout self-assigned this Mar 30, 2022
@korthout korthout mentioned this issue Mar 30, 2022
Merged
10 tasks
@remcowesterhoud remcowesterhoud mentioned this issue Mar 30, 2022
Closed
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korthout korthout

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly depend on google-java-format camunda/camunda
3 participants
@deepthidevaki @Zelldon @korthout