Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to deploy snapshots to Maven (presumably since switch to 8.1) #9087

Closed
pihme opened this issue Apr 11, 2022 · 4 comments · Fixed by #9088
Closed

Unable to deploy snapshots to Maven (presumably since switch to 8.1) #9087

pihme opened this issue Apr 11, 2022 · 4 comments · Fixed by #9088
Assignees
@npepinpe
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@pihme
Copy link
Contributor

pihme commented Apr 11, 2022

Description

Since this week we are unable to deploy snapshots to Maven. The upload step hangs with the following error message:

[2022-04-11T09:55:13.579Z] [INFO] Waiting for other projects build to finish...
[2022-04-11T09:55:15.477Z] [INFO] Waiting for other projects build to finish...
[2022-04-11T09:55:17.373Z] [INFO] Waiting for other projects build to finish...
[2022-04-11T09:55:19.270Z] [INFO] Waiting for other projects build to finish...
[2022-04-11T09:55:21.794Z] [INFO] Waiting for other projects build to finish...
[2022-04-11T09:55:23.691Z] [INFO] Waiting for other projects build to finish...
[2022-04-11T09:55:24.505Z] Sending interrupt signal to process
[2022-04-11T09:55:24.505Z] Killing processes
[2022-04-11T09:55:24.830Z] kill finished with exit code 0

There is this bug which sounds similar in terms of symptoms https://issues.sonatype.org/browse/NEXUS-6735

However, AFAIK we are not using the config property mentioned and we don't skip modules.
@pihme pihme added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Apr 11, 2022
@pihme
Copy link
Contributor Author

pihme commented Apr 11, 2022

Slack communication: https://camunda.slack.com/archives/CSQ2E3BT4/p1649670981498129

@pihme pihme mentioned this issue Apr 11, 2022
Closed
@npepinpe
Copy link
Member

npepinpe commented Apr 11, 2022 •
edited
Loading

The commit which triggered this (here) removed a module. I'm wondering if this isn't the problem. But then, is there no way to remove modules in Maven?

@npepinpe
Copy link
Member

It looks like the zeebe-protocol is the module which starts being deployed but never gets deployed. My guess is the generation of the Javadoc is an issue, or the source JAR, not sure which one, but these are steps we rarely do except during deployment.

@npepinpe
Copy link
Member

Yup, there's an error when generating the Javadoc for the protocol module starting at this commit. I'm curious why it fails the deployment but no error is printed out. Should we start generating (or if possible only validating) the Javadoc in our build phase as well?

@npepinpe npepinpe mentioned this issue Apr 11, 2022
Merged
10 tasks
@npepinpe npepinpe self-assigned this Apr 11, 2022
zeebe-bors-camunda bot added a commit that referenced this issue Apr 11, 2022
@zeebe-bors-camunda @npepinpe
merge: #9088
c475269 
9088: Fix javadoc generation during module deployment r=pihme a=npepinpe

## Description

This PR fixes snapshot deployments (and generally all deployments, I assume). Ensure that we compile sources (and not just generate them) to ensure annotation preprocessor sources are generated and resolve-able when generating the Javadoc.

## Related issues

closes #9087 



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 11, 2022
@zeebe-bors-camunda @npepinpe
merge: #9088
a31d0a7 
9088: Fix javadoc generation during module deployment r=pihme a=npepinpe

## Description

This PR fixes snapshot deployments (and generally all deployments, I assume). Ensure that we compile sources (and not just generate them) to ensure annotation preprocessor sources are generated and resolve-able when generating the Javadoc.

## Related issues

closes #9087 



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 11, 2022
@zeebe-bors-camunda @npepinpe
merge: #9088
e1722bb 
9088: Fix javadoc generation during module deployment r=pihme a=npepinpe

## Description

This PR fixes snapshot deployments (and generally all deployments, I assume). Ensure that we compile sources (and not just generate them) to ensure annotation preprocessor sources are generated and resolve-able when generating the Javadoc.

## Related issues

closes #9087 



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npepinpe npepinpe

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix javadoc generation during module deployment camunda/camunda
4 participants
@npepinpe @deepthidevaki @Zelldon @pihme