Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an empty topology when no there is no known topology #9096

Closed
npepinpe opened this issue Apr 11, 2022 · 1 comment · Fixed by #9360
Closed

Return an empty topology when no there is no known topology #9096

npepinpe opened this issue Apr 11, 2022 · 1 comment · Fixed by #9360
Assignees
Labels
area/ux Marks an issue as related to improving the user experience kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/gateway Marks an issue or PR to appear in the gateway section of the changelog version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Milestone

Comments

@npepinpe
Copy link
Member

Description

When the client makes a topology call to the gateway, if the gateway hasn't computed any topology, it currently returns UNAVAILABLE. However, when it has one (even if it's empty), it will return an empty topology.

For normal calls that require a partition (which is to say, most calls), when there is an empty topology or no known topology, we always return UNAVAILABLE. This makes perfect sense, since the gateway acts as a proxy, and in that sense upstream is not available.

However, the topology call is a way to introspect the view of the cluster from the gateway's point of view. Returning UNAVAILABLE hides that and makes it hard to distinguish between a call where the gateway is unavailable and where the topology is simply not known.

I would propose instead to simply return an empty topology. The smoke test in StandaloneGatewayIT would have to be updated to account for this, and possibly other tests.

@npepinpe npepinpe added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Apr 11, 2022
@npepinpe
Copy link
Member Author

Extracted from #9077

@npepinpe npepinpe added scope/gateway Marks an issue or PR to appear in the gateway section of the changelog area/ux Marks an issue as related to improving the user experience labels Apr 12, 2022
@npepinpe npepinpe added this to the 8.1 milestone Apr 12, 2022
@remcowesterhoud remcowesterhoud self-assigned this May 11, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Marks an issue as related to improving the user experience kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/gateway Marks an issue or PR to appear in the gateway section of the changelog version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants