Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate manual QA instructions for OAuth integration tests #9119

Closed
npepinpe opened this issue Apr 13, 2022 · 1 comment · Fixed by #9562
Closed

Automate manual QA instructions for OAuth integration tests #9119

npepinpe opened this issue Apr 13, 2022 · 1 comment · Fixed by #9562
Assignees
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

Description

When we initially implemented the OAuth credentials provider (both for Go and Java), me and Miguel added some helpers to run integration tests against real OAuth2 providers under clients/oauth2, with some instructions on how to use them. These would setup what we expected would be similar to a production set up - a reverse proxy in front of Zeebe performing the authentication, and an OAuth2 provider.

This helped us catch two bugs after the initial release, so it was useful, but it hasn't really be used ever since and most likely is outdated at this point. It also doesn't help us prevent further bugs since we don't run this as part of our normal QA.

I would propose replacing the tests with just a simple integration test for each client that tests a plain OAuthCredentialsProvider (in Java and in Go) against a real provider, likely hydra as it's the lighter one (Keycloak takes a good 30s to just start up versus hydra which takes a couple).

@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation area/maintainability Marks an issue as improving the maintainability of the project labels Apr 13, 2022
@npepinpe
Copy link
Member Author

Leaving it in the backlog for now as there is no major changes planned for the Java/Go client at the moment.

@npepinpe npepinpe self-assigned this Jun 21, 2022
@lenaschoenburg lenaschoenburg added the version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 label Jul 5, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants