Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go client to use 1.17 #9270

Closed
npepinpe opened this issue May 2, 2022 · 3 comments · Fixed by #9566 or #9577
Closed

Update Go client to use 1.17 #9270

npepinpe opened this issue May 2, 2022 · 3 comments · Fixed by #9566 or #9577
Assignees
@pihme
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/clients-go Marks an issue or PR to appear in the Go client section of the changelog scope/zbctl Marks an issue or PR to appear in the zbctl section of the changelog version:1.3.11 Marks an issue as being completely or in parts released in 1.3.11 version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Milestone
8.1

Comments

@npepinpe
Copy link
Member

npepinpe commented May 2, 2022

Description

Our Go client is now built against 1.15, which is not supported anymore. We should start building against Go 1.17, which is the lowest support version.
@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/clients-go Marks an issue or PR to appear in the Go client section of the changelog scope/zbctl Marks an issue or PR to appear in the zbctl section of the changelog area/maintainability Marks an issue as improving the maintainability of the project team/process-automation labels May 2, 2022
@npepinpe
Copy link
Member Author

npepinpe commented May 2, 2022

Our CI will have to be updated to account for this.

@npepinpe npepinpe added this to the 8.1 milestone May 3, 2022
@aivinog1
Copy link
Contributor

Also, needs to keep in mind, that go get ... is deprecated in the Go 1.17, and needs to update this instruction, for example

@lenaschoenburg lenaschoenburg mentioned this issue May 20, 2022
Merged
@lenaschoenburg
Copy link
Member

Please backport this to 1.3 as well to resolve #9427

@lenaschoenburg lenaschoenburg mentioned this issue May 20, 2022
Closed
zeebe-bors-camunda bot added a commit that referenced this issue May 23, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #9433
7915e11 
9433: Update vulnerable versions of netty and spring in 1.3.8 r=deepthidevaki a=oleschoenburg

Updates netty & spring to non-vulnerable versions. 

Relates to #9427 

We'll upgrade the go version in #9270, we'll just need to backport it.

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue May 24, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #9433
a753fb8 
9433: Update vulnerable versions of netty and spring in 1.3.8 r=deepthidevaki a=oleschoenburg

Updates netty & spring to non-vulnerable versions. 

Relates to #9427 

We'll upgrade the go version in #9270, we'll just need to backport it.

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@pihme pihme self-assigned this Jun 22, 2022
This was referenced Jun 22, 2022
Merged
Merged
@pihme pihme mentioned this issue Jun 22, 2022
Merged
10 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Jun 22, 2022
@zeebe-bors-camunda @pihme
merge: #9574
3feedbd 
9574: Bump go to 1.17 in 8.0 r=pihme a=pihme

## Description

- Bump Go version to 1.17

## Related issues

closes #9270 



Co-authored-by: pihme <pihme@users.noreply.github.com>
@pihme pihme mentioned this issue Jun 22, 2022
Merged
10 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Jun 22, 2022
@zeebe-bors-camunda @pihme
merge: #9574
ec656da 
9574: Bump go to 1.17 in 8.0 r=pihme a=pihme

## Description

- Bump Go version to 1.17

## Related issues

closes #9270 



Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 23, 2022
@zeebe-bors-camunda @pihme
merge: #9571
72c5589 
9571: 9270 bump go to 1.17 in 1.3 r=pihme a=pihme

## Description
- Bumps Go to version 1.17

**Review Hints**

- Does not remove deprecated code (there will be follow up issues for that)
## Related issues

closes #9270



Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 23, 2022
@zeebe-bors-camunda @pihme
merge: #9577
3898b72 
9577: Set go version to 1.17 addendum r=pihme a=pihme

## Description

- Sets go to 1.17 in the places I missed before
- Reads go version from `go.mod` file
- Enables caching for Go artifacts

**Review hints**
The last commit - enabling caching - is debatable. It doesn't add much, because the slow parts of the build are in the Java and Docker parts, not the go steps.

## Related issues

closes #9270



Co-authored-by: pihme <pihme@users.noreply.github.com>
@lenaschoenburg lenaschoenburg added the version:1.3.11 Marks an issue as being completely or in parts released in 1.3.11 label Jun 27, 2022
@lenaschoenburg lenaschoenburg added the version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 label Jul 5, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pihme pihme

Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/clients-go Marks an issue or PR to appear in the Go client section of the changelog scope/zbctl Marks an issue or PR to appear in the zbctl section of the changelog version:1.3.11 Marks an issue as being completely or in parts released in 1.3.11 version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
8.1
5 participants
@npepinpe @lenaschoenburg @Zelldon @pihme @aivinog1