Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot and SnapshotStore toString implementations are recursive #9828

Closed
lenaschoenburg opened this issue Jul 18, 2022 · 0 comments · Fixed by #9829
Closed

Snapshot and SnapshotStore toString implementations are recursive #9828

lenaschoenburg opened this issue Jul 18, 2022 · 0 comments · Fixed by #9829
Assignees
@lenaschoenburg
Labels
area/observability Marks an issue as observability related area/performance Marks an issue as performance related kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@lenaschoenburg
Copy link
Member

The toString implementation of FileBasedSnapshotStore and FileBasedReceivedSnapshot are recursive, causing a stack overflow while logging:

RaftServer{raft-partition-partition-3}{role=FOLLOWER} - Started receiving new snapshot [!!!io.camunda.zeebe.snapshots.impl.FileBasedReceivedSnapshot@5197510d=>java.lang.StackOverflowError:null!!!] from 0

Originally posted by @oleschoenburg in #9737 (comment)
@lenaschoenburg lenaschoenburg self-assigned this Jul 18, 2022
@lenaschoenburg lenaschoenburg added area/performance Marks an issue as performance related area/observability Marks an issue as observability related kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user labels Jul 18, 2022
@lenaschoenburg lenaschoenburg mentioned this issue Jul 18, 2022
Merged
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaschoenburg lenaschoenburg

Labels
area/observability Marks an issue as observability related area/performance Marks an issue as performance related kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent endless recursion in toString of snapshot and store camunda/camunda
3 participants
@npepinpe @lenaschoenburg @Zelldon