Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followers should return the full partition status for the /partitions actuator #9970

Closed
lenaschoenburg opened this issue Aug 3, 2022 · 0 comments · Fixed by #12693
Closed

Followers should return the full partition status for the /partitions actuator #9970

lenaschoenburg opened this issue Aug 3, 2022 · 0 comments · Fixed by #12693
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@lenaschoenburg
Copy link
Member

Description

In BrokerAdminServiceImpl we distinguish between leaders and followers. For leaders:
https://github.com/camunda/zeebe/blob/6720e2e25e9432901c478b62491608d8048343f3/broker/src/main/java/io/camunda/zeebe/broker/system/management/BrokerAdminServiceImpl.java#L202-L208
For followers:
https://github.com/camunda/zeebe/blob/6720e2e25e9432901c478b62491608d8048343f3/broker/src/main/java/io/camunda/zeebe/broker/system/management/BrokerAdminServiceImpl.java#L164-L165

I believe this is not necessary since followers replay and all information that we return for leaders is also available on followers.

This would make writing some integration tests easier, for example for #9954
@lenaschoenburg lenaschoenburg added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 3, 2022
Merged
14 tasks
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes linked a pull request May 8, 2023 that will close this issue
#9970 Followers should return the full partition status for the /partitions actuator. #12693
Merged
14 tasks
@lenaschoenburg lenaschoenburg added the version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 label Jun 7, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Milestone
No milestone
2 participants
@megglos @lenaschoenburg