refactor: let dist build the actor scheduler for gateway
#10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
approved these changes
Aug 5, 2022
dist/src/main/java/io/camunda/zeebe/gateway/ActorSchedulerComponent.java
Outdated
Show resolved
Hide resolved
dist/src/main/java/io/camunda/zeebe/gateway/ActorSchedulerComponent.java
Outdated
Show resolved
Hide resolved
dist/src/main/java/io/camunda/zeebe/gateway/ActorSchedulerComponent.java
Outdated
Show resolved
Hide resolved
lenaschoenburg
force-pushed
the
9996-dist-builds-gateway-actorscheduler
branch
from
9f99f7f
to
bed684b
Compare
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 5, 2022
9989: Create engine outside r=Zelldon a=Zelldon ## Description Create the engine outside of the StreamProcessor, which should allow to also inject other RecordProcessors. Furthermore we can fill the Engine with the needed TypedRecordProcessorFactory, which means we no longer need that in our builders and contexts. I hope this helps you in make further progress `@deepthidevaki` Sidenote: This also simplifies the StreamProcessor/RecordProcessor tests, since we do not necessarily need to set up so much anymore. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #9725 10012: refactor: let `dist` build the actor scheduler for gateway r=oleschoenburg a=oleschoenburg ## Description This moves the responsibility of creating an actor scheduler for the gateway to the `dist` module. As an added benefit, this allows us to remove some redundant constructors, simplify BrokerClient to never start the actor scheduler and a deprecated method from `BrokerStartupContext`. ## Related issues <!-- Which issues are closed by this PR or are related --> relates to #9996 Co-authored-by: Christopher Zell <zelldon91@googlemail.com> Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Oops, looks like I forgot to start the actor scheduler somewhere bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
zeebe-bors-camunda
bot
deleted the
9996-dist-builds-gateway-actorscheduler
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the responsibility of creating an actor scheduler for the gateway to the
distmodule. As an added benefit, this allows us to remove some redundant constructors, simplify BrokerClient to never start the actor scheduler and a deprecated method fromBrokerStartupContext.Related issues
relates to #9996
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.