Fix flaky MultiPartitionDeploymentLifecycleTest

[remcowesterhoud]

Description

Test was flaky because it was asserted that the COMPLETE commands and COMPLETED events were written in order.
This is not always as the case. The COMPLETE commands are a result of partition 2 and 3 sending the command to partition 1. There is no guarantee that partition 1 will first receive both commands before it starts processing them.
As long as we assert that we receive the COMPLETE command of partition X before the COMPLETED event of partition X the test should be accurate without being flaky.

Related issues

closes #9964

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually
• The change has been verified by a QA run
• The impact of the changes is verified by a benchmark

Documentation:

• The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
• New content is added to the release announcement
• If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

[github-actions]

Test Results

   847 files  +    1     847 suites  +1   1h 41m 19s ⏱️ + 2m 41s
6 571 tests +210  6 559 ✔️ +209  11 💤 ±0  1 ❌ +1 
6 755 runs  +210  6 743 ✔️ +209  11 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 907b0e4. ± Comparison against base commit 403c25a.

♻️ This comment has been updated with latest results.

[remcowesterhoud]

@pihme Just pinging you to make sure you've seen this PR

[pihme]

Thanks for the reminder. I wasn't aware of it.

[pihme]

Great improvement, but I think it can be improved further

[pihme]

Oh, and maybe we want to backport this

[remcowesterhoud]

@pihme I have removed all the hardcoded indexes, please have another look!

[remcowesterhoud]

We can backport them. The test wasn't flaky in previous versions though, as it was introduced with the new inter partition command sending.

[pihme]

lgtm 🎉

[remcowesterhoud]

bors merge

[zeebe-bors-camunda]

Build succeeded:

• Go linting
• Java checks
• Test summary

[backport-action]

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-10065-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-10065-to-stable/1.3
git checkout -b backport-10065-to-stable/1.3
ancref=$(git merge-base 396f1854c7da6ae6866897200af34b797379b85d 369e5a1edbcdcf08cca41b464faa7aa3602ce72b)
git cherry-pick -x $ancref..369e5a1edbcdcf08cca41b464faa7aa3602ce72b

[backport-action]

Successfully created backport PR #10091 for stable/8.0.