-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move QA test utilities to their own module #10092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I would backport this to at least 8.0 as well to avoid issues backporting more things in the future. Let me know if you disagree |
bors merge |
makes sense to me |
Build succeeded: |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-10092-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-10092-to-stable/1.3
git checkout -b backport-10092-to-stable/1.3
ancref=$(git merge-base 099d01636105b5404fb9d784b9d629ea3dbcd5ee 9eaa3c96a5559dd36883acf33802ac10b2f87177)
git cherry-pick -x $ancref..9eaa3c96a5559dd36883acf33802ac10b2f87177 |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-10092-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-10092-to-stable/8.0
git checkout -b backport-10092-to-stable/8.0
ancref=$(git merge-base 099d01636105b5404fb9d784b9d629ea3dbcd5ee 9eaa3c96a5559dd36883acf33802ac10b2f87177)
git cherry-pick -x $ancref..9eaa3c96a5559dd36883acf33802ac10b2f87177 |
Opted to backport only to 8.0. More changes are necessary for 1.3, and we'll only be backporting for the next month, so 🤞 Let me know if you disagree 👍 |
10097: [Backport stable/8.0] Move QA test utilities to their own module r=npepinpe a=npepinpe ## Description This PR backports #10092 to stable/8.0. The only conflict worth mentioning was that we'd previously rewritten `DiskSpaceRecoveryITTest`, and I opted not to touch here instead, just updating the import statements. ## Related issues backports #10092 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
Description
This PR introduces a new module,
zeebe-qa-util
, under thezeebe-qa
umbrella module. The module is located atqa/util/pom.xml
. QA utilities from thetest-util
module were moved there as well. No real changes were done other than move things around.Related issues
closes #10089
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.