Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move QA test utilities to their own module #10092

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Conversation

npepinpe
Copy link
Member

Description

This PR introduces a new module, zeebe-qa-util, under the zeebe-qa umbrella module. The module is located at qa/util/pom.xml. QA utilities from the test-util module were moved there as well. No real changes were done other than move things around.

Related issues

closes #10089

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

Test Results

   847 files  ±  0     847 suites  ±0   1h 41m 3s ⏱️ + 2m 8s
6 367 tests +43  6 356 ✔️ +43  11 💤 ±0  0 ±0 
6 551 runs  +43  6 540 ✔️ +43  11 💤 ±0  0 ±0 

Results for commit 9eaa3c9. ± Comparison against base commit 099d016.

@npepinpe npepinpe requested a review from Zelldon August 17, 2022 11:21
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@npepinpe
Copy link
Member Author

I would backport this to at least 8.0 as well to avoid issues backporting more things in the future. Let me know if you disagree

@npepinpe
Copy link
Member Author

bors merge

@Zelldon
Copy link
Member

Zelldon commented Aug 17, 2022

makes sense to me

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 1007ab2 into main Aug 17, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 10089-qa-util branch August 17, 2022 11:43
@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-10092-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-10092-to-stable/1.3
git checkout -b backport-10092-to-stable/1.3
ancref=$(git merge-base 099d01636105b5404fb9d784b9d629ea3dbcd5ee 9eaa3c96a5559dd36883acf33802ac10b2f87177)
git cherry-pick -x $ancref..9eaa3c96a5559dd36883acf33802ac10b2f87177

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-10092-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-10092-to-stable/8.0
git checkout -b backport-10092-to-stable/8.0
ancref=$(git merge-base 099d01636105b5404fb9d784b9d629ea3dbcd5ee 9eaa3c96a5559dd36883acf33802ac10b2f87177)
git cherry-pick -x $ancref..9eaa3c96a5559dd36883acf33802ac10b2f87177

@npepinpe
Copy link
Member Author

Opted to backport only to 8.0. More changes are necessary for 1.3, and we'll only be backporting for the next month, so 🤞 Let me know if you disagree 👍

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 18, 2022
10097: [Backport stable/8.0] Move QA test utilities to their own module r=npepinpe a=npepinpe

## Description

This PR backports #10092 to stable/8.0. The only conflict worth mentioning was that we'd previously rewritten `DiskSpaceRecoveryITTest`, and I opted not to touch here instead, just updating the import statements.

## Related issues

backports #10092 



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new utility module specifically for QA tests
4 participants